Petals Studio

Be able to build Petals Studio with Maven Tycho

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1.1
  • Fix Version/s: 1.2.0
  • Component/s: Studio Product
  • Security Level: Public
  • Description:

    POM files and a parent project should be added to support Tycho builds.

  • Environment:
    All

Issue Links

Activity

Hide
Vincent Zurczak added a comment - Fri, 6 May 2011 - 18:46:45 +0200

Because I'm willing to set it up as soon as possible...

Show
Vincent Zurczak added a comment - Fri, 6 May 2011 - 18:46:45 +0200 Because I'm willing to set it up as soon as possible...
Vincent Zurczak made changes - Fri, 6 May 2011 - 18:46:45 +0200
Field Original Value New Value
Status New [ 10000 ] Open [ 10002 ]
Priority Major [ 3 ]
Vincent Zurczak made changes - Fri, 6 May 2011 - 18:46:48 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Vincent Zurczak made changes - Fri, 6 May 2011 - 20:29:06 +0200
Status In Progress [ 10003 ] Open [ 10002 ]
Vincent Zurczak made changes - Tue, 10 May 2011 - 13:43:13 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Hide
Vincent Zurczak added a comment - Tue, 10 May 2011 - 20:17:24 +0200

Commits # 1937 to # 1948
Add POM files in all the projects and in all the intermediate directories
Add a parent project
Add a target-definition project
Add a project for the product definition
Add a new RCP feature for Tycho builds

For the moment, Tycho and PDE builds will coexist. Tycho is still missing some features (for the shape... Otherwise, built products work). PDE builds will be removed as soon as Tycho supprts these features.
The most important one to expect is a correct support for branding (with the about dialog).

For the record, here is what needs to be completed to close this bug:

  • Customize the icons for Windows executables.
  • Be able to complete and update the about dialog.
  • Remove root files like epl-v10.html and others ones which are added by the Eclipse RCP feature (an ANT script should do the trick).
  • Move the plugin_customiation.ini file in the configuration sub-directory.
  • Test these builds under Linux.
Show
Vincent Zurczak added a comment - Tue, 10 May 2011 - 20:17:24 +0200 Commits # 1937 to # 1948 Add POM files in all the projects and in all the intermediate directories Add a parent project Add a target-definition project Add a project for the product definition Add a new RCP feature for Tycho builds For the moment, Tycho and PDE builds will coexist. Tycho is still missing some features (for the shape... Otherwise, built products work). PDE builds will be removed as soon as Tycho supprts these features. The most important one to expect is a correct support for branding (with the about dialog). For the record, here is what needs to be completed to close this bug:
  • Customize the icons for Windows executables.
  • Be able to complete and update the about dialog.
  • Remove root files like epl-v10.html and others ones which are added by the Eclipse RCP feature (an ANT script should do the trick).
  • Move the plugin_customiation.ini file in the configuration sub-directory.
  • Test these builds under Linux.
Vincent Zurczak made changes - Tue, 10 May 2011 - 20:17:24 +0200
Status In Progress [ 10003 ] Open [ 10002 ]
Vincent Zurczak made changes - Tue, 10 May 2011 - 20:27:13 +0200
Link This issue blocks PETALSSTUD-2 [ PETALSSTUD-2 ]
Vincent Zurczak made changes - Thu, 12 May 2011 - 12:31:30 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Hide
Vincent Zurczak added a comment - Thu, 12 May 2011 - 12:32:13 +0200 - edited

Commit # 1949
Repair the about dialog
Set the icons for Windows executables

Show
Vincent Zurczak added a comment - Thu, 12 May 2011 - 12:32:13 +0200 - edited Commit # 1949 Repair the about dialog Set the icons for Windows executables
Vincent Zurczak made changes - Thu, 12 May 2011 - 12:32:13 +0200
Status In Progress [ 10003 ] Open [ 10002 ]
Vincent Zurczak made changes - Fri, 13 May 2011 - 18:27:53 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Hide
Vincent Zurczak added a comment - Fri, 13 May 2011 - 21:11:17 +0200

Commits # 1953 to # 1956
Ignore target directories

About the root files, ANT does not work (no intermediate phase between the materialization and the archive creation).
TODO: ask on the ML and/or create a feature request for that

A script shell might do the job, with a release profile to run under Linux.

Show
Vincent Zurczak added a comment - Fri, 13 May 2011 - 21:11:17 +0200 Commits # 1953 to # 1956 Ignore target directories About the root files, ANT does not work (no intermediate phase between the materialization and the archive creation). TODO: ask on the ML and/or create a feature request for that A script shell might do the job, with a release profile to run under Linux.
Vincent Zurczak made changes - Fri, 13 May 2011 - 21:11:17 +0200
Status In Progress [ 10003 ] Open [ 10002 ]
Vincent Zurczak made changes - Thu, 19 May 2011 - 20:49:47 +0200
Status Open [ 10002 ] In Progress [ 10003 ]
Hide
Vincent Zurczak added a comment - Thu, 19 May 2011 - 23:27:34 +0200

Commit # 1960
Rename the generated archives
Commented samples to remove the extra files

There are still 3 files that are embedded in the final zip and which should not. They are not conflicting with other files, they are just useless.
+ readme (directory)
+ notice.html
+ epl-v10.html

They come from the RCP feature. Since Maven and ANT are too heavy to invoke a light-weight cleaning script, these files will have to be removed manually. The POM includes commented snippets with a Groovy script and another ANT task that should be used with ANT-contrib. Since Maven downloads the entire internet for these solutions to work, they were disabled. A feature request will be posted on Tycho's JIRA for a new goal and phase that will address this issue.

Also, note that Maven builds fail for MacOS distributions (with builds on Linux and Windows).
This is due to a bug in Tycho. See https://issues.sonatype.org/browse/TYCHO-520 for more details.
Since MacOS is not officially supported, this is a minor thing we will fix later. I consider the move toward Maven builds done.

Show
Vincent Zurczak added a comment - Thu, 19 May 2011 - 23:27:34 +0200 Commit # 1960 Rename the generated archives Commented samples to remove the extra files There are still 3 files that are embedded in the final zip and which should not. They are not conflicting with other files, they are just useless. + readme (directory) + notice.html + epl-v10.html They come from the RCP feature. Since Maven and ANT are too heavy to invoke a light-weight cleaning script, these files will have to be removed manually. The POM includes commented snippets with a Groovy script and another ANT task that should be used with ANT-contrib. Since Maven downloads the entire internet for these solutions to work, they were disabled. A feature request will be posted on Tycho's JIRA for a new goal and phase that will address this issue. Also, note that Maven builds fail for MacOS distributions (with builds on Linux and Windows). This is due to a bug in Tycho. See https://issues.sonatype.org/browse/TYCHO-520 for more details. Since MacOS is not officially supported, this is a minor thing we will fix later. I consider the move toward Maven builds done.
Vincent Zurczak made changes - Thu, 19 May 2011 - 23:27:34 +0200
Status In Progress [ 10003 ] Resolved [ 10004 ]
Fix Version/s 1.2.0 [ 10079 ]
Resolution Fixed [ 1 ]
Vincent Zurczak made changes - Thu, 19 May 2011 - 23:27:41 +0200
Status Resolved [ 10004 ] Closed [ 10005 ]
Hide
Vincent Zurczak added a comment - Sat, 21 May 2011 - 22:23:05 +0200

There are still 3 files that are embedded in the final zip and which should not. They are not conflicting with other files, they are just useless.
+ readme (directory)
+ notice.html
+ epl-v10.html

I managed to delete these files by adding instructions in the p2.inf file.
No need of ANT or Maven...

Show
Vincent Zurczak added a comment - Sat, 21 May 2011 - 22:23:05 +0200
There are still 3 files that are embedded in the final zip and which should not. They are not conflicting with other files, they are just useless. + readme (directory) + notice.html + epl-v10.html
I managed to delete these files by adding instructions in the p2.inf file. No need of ANT or Maven...
Transition Status Change Time Execution Times Last Executer Last Execution Date
New New Open Open
16d 23h
1
Vincent Zurczak
Fri, 6 May 2011 - 18:46:45 +0200
Open Open In Progress In Progress
3s
1
Vincent Zurczak
Fri, 6 May 2011 - 18:46:48 +0200
In Progress In Progress Open Open
1h 42m
1
Vincent Zurczak
Fri, 6 May 2011 - 20:29:06 +0200
Open Open In Progress In Progress
3d 17h 14m
1
Vincent Zurczak
Tue, 10 May 2011 - 13:43:13 +0200
In Progress In Progress Open Open
6h 34m
1
Vincent Zurczak
Tue, 10 May 2011 - 20:17:24 +0200
Open Open In Progress In Progress
1d 16h 14m
1
Vincent Zurczak
Thu, 12 May 2011 - 12:31:30 +0200
In Progress In Progress Open Open
43s
1
Vincent Zurczak
Thu, 12 May 2011 - 12:32:13 +0200
Open Open In Progress In Progress
1d 5h 55m
1
Vincent Zurczak
Fri, 13 May 2011 - 18:27:53 +0200
In Progress In Progress Open Open
2h 43m
1
Vincent Zurczak
Fri, 13 May 2011 - 21:11:17 +0200
Open Open In Progress In Progress
5d 23h 38m
1
Vincent Zurczak
Thu, 19 May 2011 - 20:49:47 +0200
In Progress In Progress Resolved Resolved
2h 37m
1
Vincent Zurczak
Thu, 19 May 2011 - 23:27:34 +0200
Resolved Resolved Closed Closed
7s
1
Vincent Zurczak
Thu, 19 May 2011 - 23:27:41 +0200

People

Dates

  • Created:
    Tue, 19 Apr 2011 - 19:46:03 +0200
    Updated:
    Sat, 21 May 2011 - 22:23:05 +0200
    Resolved:
    Thu, 19 May 2011 - 23:27:34 +0200