Petals CDK

Remove or refactor Exceptions around Fault

Details

  • Type: Task Task
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 5.4.3
  • Fix Version/s: 5.5.0
  • Component/s: Utils
  • Security Level: Public
  • Description:
    Hide

    As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault.

    Now that PETALSCDK-130 is closed, FaultException, DocumentException, SOAP11FaultServerException and SOAP11FaultClientException should be removed from the CDK.

    Note: these exception were used previously by components to build faults that were coherent with their WSDL: for that case, we should provide utils to create Fault from a Document or other XML in-memory representation of a fault.
    But that shouldn't be done using Java exceptions (except maybe for the case of the POJO that seems to be relying on it... maybe we should move that "exception-based fault handling" logic to the pojo if we think current users of the component are exploiting them! (or provides an easy to use alternative)).

    Show
    As per PETALSDISTRIB-133, technical errors should be kept as errors and not transformed to fault. Now that PETALSCDK-130 is closed, FaultException, DocumentException, SOAP11FaultServerException and SOAP11FaultClientException should be removed from the CDK. Note: these exception were used previously by components to build faults that were coherent with their WSDL: for that case, we should provide utils to create Fault from a Document or other XML in-memory representation of a fault. But that shouldn't be done using Java exceptions (except maybe for the case of the POJO that seems to be relying on it... maybe we should move that "exception-based fault handling" logic to the pojo if we think current users of the component are exploiting them! (or provides an easy to use alternative)).
  • Environment:
    -

Issue Links

Depends

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Victor NOËL added a comment - Thu, 21 May 2015 - 17:16:43 +0200

This is mainly related to the fact that components call setFault(Throwable) on an Exchange from the CDK.

Show
Victor NOËL added a comment - Thu, 21 May 2015 - 17:16:43 +0200 This is mainly related to the fact that components call setFault(Throwable) on an Exchange from the CDK.
Hide
Permalink
Victor NOËL added a comment - Fri, 22 May 2015 - 17:06:57 +0200

Issues for all impacted components are linked (except for the BPEL SE that is not supported anymore).

Fixing all these issues means to remove altogether the setFault(Throwable) method and the corresponding Exceptions from the CDK.
Some of them may be moved to the POJO but the SOAP aspect of it removed (see PETALSCDK-133 for details).

Show
Victor NOËL added a comment - Fri, 22 May 2015 - 17:06:57 +0200 Issues for all impacted components are linked (except for the BPEL SE that is not supported anymore). Fixing all these issues means to remove altogether the setFault(Throwable) method and the corresponding Exceptions from the CDK. Some of them may be moved to the POJO but the SOAP aspect of it removed (see PETALSCDK-133 for details).
Hide
Permalink
Victor NOËL added a comment - Wed, 15 Jul 2015 - 12:01:09 +0200

FaultException was moved (and rewritten) for the POJO SE. The other exceptions were removed as well as setFault(Throwable)

Show
Victor NOËL added a comment - Wed, 15 Jul 2015 - 12:01:09 +0200 FaultException was moved (and rewritten) for the POJO SE. The other exceptions were removed as well as setFault(Throwable)

People

Dates

  • Created:
    Thu, 21 May 2015 - 17:09:26 +0200
    Updated:
    Wed, 15 Jul 2015 - 13:48:35 +0200
    Resolved:
    Wed, 15 Jul 2015 - 13:40:21 +0200
Atlassian JIRA (v4.1.2#531) | Report a problem | Request a feature | Contact administrators
Powered by a free Atlassian JIRA open source license for Petals ESB. Try JIRA - bug tracking software for your team.